[
https://issues.apache.org/jira/browse/SOLR-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562220#comment-14562220
]
Anshum Gupta commented on SOLR-7602:
------------------------------------
Seems like the changes in SOLR-7408 triggered this. Since that change,
solrCore.close() is called for every failed creation attempt i.e. in case of an
exception during Core creation.
SolrCore.close has this check:
{code}
int count = refCount.decrementAndGet(); // #1
if (count > 0) return; // close is called often, and only actually closes
if nothing is using it.
if (count < 0) {
log.error("Too many close [count:{}] on {}. Please report this exception
to [email protected]", count, this );
assert false : "Too many closes on SolrCore";
return;
}
{code}
When the core creation fails, #1 could return -1.
We should bypass this check in such cases or increment the refCount as the
first thing during creation.
> Frequent MultiThreadedOCPTest failures on Jenkins
> -------------------------------------------------
>
> Key: SOLR-7602
> URL: https://issues.apache.org/jira/browse/SOLR-7602
> Project: Solr
> Issue Type: Bug
> Reporter: Anshum Gupta
>
> The number of failed MultiThreadedOCPTest runs on Jenkins has gone up
> drastically since Apr 30, 2015.
> {code}
> REGRESSION: org.apache.solr.cloud.MultiThreadedOCPTest.test
> Error Message:
> Captured an uncaught exception in thread: Thread[id=6313,
> name=parallelCoreAdminExecutor-1988-thread-15, state=RUNNABLE,
> group=TGRP-MultiThreadedOCPTest]
> Stack Trace:
> com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an
> uncaught exception in thread: Thread[id=6313,
> name=parallelCoreAdminExecutor-1988-thread-15, state=RUNNABLE,
> group=TGRP-MultiThreadedOCPTest]
> at
> __randomizedtesting.SeedInfo.seed([1FD11A82D96D185B:97852558779175A3]:0)
> Caused by: java.lang.AssertionError: Too many closes on SolrCore
> at __randomizedtesting.SeedInfo.seed([1FD11A82D96D185B]:0)
> at org.apache.solr.core.SolrCore.close(SolrCore.java:1138)
> at org.apache.solr.common.util.IOUtils.closeQuietly(IOUtils.java:31)
> at org.apache.solr.core.CoreContainer.create(CoreContainer.java:535)
> at org.apache.solr.core.CoreContainer.create(CoreContainer.java:494)
> at
> org.apache.solr.handler.admin.CoreAdminHandler.handleCreateAction(CoreAdminHandler.java:598)
> at
> org.apache.solr.handler.admin.CoreAdminHandler.handleRequestInternal(CoreAdminHandler.java:212)
> at
> org.apache.solr.handler.admin.CoreAdminHandler$ParallelCoreAdminHandlerThread.run(CoreAdminHandler.java:1219)
> at
> org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor$1.run(ExecutorUtil.java:148)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> Last failure:
> Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/12665/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
