[
https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562649#comment-14562649
]
Uwe Schindler commented on LUCENE-6507:
---------------------------------------
Yeah. I would like the new behaviour, more. Unfortunately there is some code in
IndexWriter currently that gets the Lock instance just to check if it is
locked. We have to review this. Maybe we can simplify the whole thing.
In any case, I will make (ähm aquire) a proposal! Maybe the Backwards
Compatibility Policeman has a good solution :-)
I also found dead code: the abstract class Lock.With class is dead (no longer
used). So we should remove.
> Directory#makeLock is trappy
> ----------------------------
>
> Key: LUCENE-6507
> URL: https://issues.apache.org/jira/browse/LUCENE-6507
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Simon Willnauer
>
> the lock API in Lucene is super trappy since the lock that we return form
> this API must first be obtained and if we can't obtain it the lock should not
> be closed since we might ie. close the underlying channel in the NativeLock
> case which releases all lock for this file on some operating systems. I think
> the makeLock method should try to obtain and only return a lock if we
> successfully obtained it. Not sure if it's possible everywhere but we should
> at least make the documentation clear here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
