[
https://issues.apache.org/jira/browse/SOLR-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563190#comment-14563190
]
Tomás Fernández Löbbe commented on SOLR-7570:
---------------------------------------------
I like the patch, the changes in ZkSolrResourceLoader look great. One question
in my mind is, will the LOCAL changes make sense for SolrCloud mode? when would
one want to change a single core? Also, looks like the collection-specific
znode is /$COLLECTION_NAME/config, we currently have
"/collections/$COLLECTION_NAME/..." for stuff like state.json, would it make
more sense for the collection specific config to be in
/collections/$COLLECTION_NAME/config/ ?
I do think that this may conflict with the discussions going on in SOLR-5955
and email list about mutable/immutable configsets and collection specific
changes... I think we should make a decision before committing any more code
related to this.
> Config APIs should not modify the ConfigSet
> -------------------------------------------
>
> Key: SOLR-7570
> URL: https://issues.apache.org/jira/browse/SOLR-7570
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomás Fernández Löbbe
> Attachments: SOLR-7570.patch
>
>
> Originally discussed here:
> http://mail-archives.apache.org/mod_mbox/lucene-dev/201505.mbox/%3CCAMJgJxSXCHxDzJs5-C-pKFDEBQD6JbgxB=-xp7u143ekmgp...@mail.gmail.com%3E
> The ConfigSet used to create a collection should be read-only. Changes made
> via any of the Config APIs should only be applied to the collection where the
> operation is done and no to other collections that may be using the same
> ConfigSet. As discussed in the dev list:
> When a collection is created we should have two things, an immutable part
> (the ConfigSet) and a mutable part (configoverlay, generated schema, etc).
> The ConfigSet will still be placed in ZooKeeper under "/configs" but the
> mutable part should be placed under "/collections/$COLLECTION_NAME/…"
> [~romseygeek] suggested:
> {quote}
> A nice way of doing it would be to make it part of the SolrResourceLoader
> interface. The ZK resource loader could check in the collection-specific
> zknode first, and then under configs/, and we could add a writeResource()
> method that writes to the collection-specific node as well. Then all config
> I/O goes via the resource loader, and we have a way of keeping certain parts
> immutable.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
