[ 
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Woodward updated LUCENE-6371:
----------------------------------
    Attachment: LUCENE-6371.patch

The patch again, this time taken from the correct point in the source tree :-/  
I've fixed the javadoc comment as well.

bq. should we consider removing it entirely?

I don't think so, it's a pretty fundamental operation.  One way of simplifying 
it might be to make SpanCollector final, and have it collect either everything 
or nothing, so that creating subcollectors is easier.  But that then makes it 
difficult to move payload collection out of core.  Or maybe instead we could 
make SpanCollector implement Cloneable, and move the responsibility of building 
subcollectors directly into NearSpansOrdered?

> Improve Spans payload collection
> --------------------------------
>
>                 Key: LUCENE-6371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6371
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch, 
> LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to