[
https://issues.apache.org/jira/browse/LUCENE-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988624#action_12988624
]
Simon Willnauer commented on LUCENE-2901:
-----------------------------------------
bq. Simon, i think the key point here is that the code does this:
so lets not rush on this - As far as I can recall this has not been released
right? so we might rather figure out what makes most sense, fixing code or
fixing javadoc. if you have 4 filters A < -- A_kw < -- B <-- B_kw <--
Tokenizer and the term is in B_kw but not in A_kw the current code does the
right thing while the change you suggest doesn't IMO. So I wonder if we should
rather fix the javadoc than the code. I mean if somebody needs this behavior
this is super simple to implement. Or maybe we have an option to reset keyword
or not?
> KeywordMarkerFilter resets keyword attribute state to false for tokens not in
> protwords.txt
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-2901
> URL: https://issues.apache.org/jira/browse/LUCENE-2901
> Project: Lucene - Java
> Issue Type: Bug
> Components: Analysis
> Affects Versions: 3.1
> Reporter: Drew Farris
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2901.patch
>
>
> KeywordMarkerFilter sets true or false for the KeywordAttribute on all
> tokens. This erases previous state established further up the filter chain,
> for example in the case where a custom filter wants to prevent a token from
> being stemmed.
> If a token is already marked as a keyword (KeywordAttribute.isKeyword() ==
> true), perhaps the KeywordMarkerFilterFactory should not re-set the state to
> false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
