[
https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587034#comment-14587034
]
Hoss Man commented on SOLR-6246:
--------------------------------
the crux of my suggestion was that we should *NOT* add any new methods to any
existing interface/abstraction, instead we could add an entirely new ReloadHook
API, and let classes pass instances of that API to Solr just like they can
currently pass instances of CloseHook.
it was a largely off the cuff suggestion, that i haven't really given any
thought to since ... i have no idea if there is a better approach.
Jan: if you think it's a good idea, then by all means go for it piecemeal ... i
honestly have no idea how serious the downsides would be during the interim
between adding a ReloadHook that the Suggester could use in one version of solr
and resolving the locking issues in a later version (corrupt suggestions index
after reload? errors when trying to add docs during reload? complete failure to
reload?) ... those ramifications seem like they should make the difference in
deciding wether the changes can be made incrementally.
> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
> Key: SOLR-6246
> URL: https://issues.apache.org/jira/browse/SOLR-6246
> Project: Solr
> Issue Type: Sub-task
> Components: SearchComponents - other
> Affects Versions: 4.8, 4.8.1, 4.9
> Reporter: Varun Thacker
> Fix For: 5.2, Trunk
>
> Attachments: SOLR-6246-test.patch, SOLR-6246-test.patch,
> SOLR-6246.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to
> AnalyzingInfixSuggester. One of the changes that went in was a writer is
> persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester
> is created. When trying to create a new writer on the same Directory a lock
> cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should
> pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a
> reloadHook where we close the writer?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
