[
https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989177#comment-12989177
]
Simon Willnauer commented on LUCENE-2831:
-----------------------------------------
bq. some recursion bugs in IndexSearcher(IndexReader r, boolean closeReader,
ExecutorService executor)
what's the recursion bug here? I have no idea why we are passing "this" to the
subs here - maybe to save a single instance?!
bq. i noticed problems with IndexSearcher(ReaderContext topLevel,
AtomicReaderContext... leaves), the varargs causes this ctor to become
ambiguous with other ctors (such as ReaderContext, ExecutorService). I don't
understand why this ctor needs to be public, i noticed Solr's QueryValueSource
is the only thing using it, and I think instead that should be fixed.
can we disambiguate by using ARC[] instead of ARC... ?
> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
> Key: LUCENE-2831
> URL: https://issues.apache.org/jira/browse/LUCENE-2831
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-2831-nuke-SolrIndexReader.patch,
> LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR,
> boolean, boolean) we should / could revise the API and pass in a struct that
> has parent reader, sub reader, ord of that sub. The ord mapping plus the
> context with its parent would make several issues way easier. See
> LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
