[ https://issues.apache.org/jira/browse/LUCENE-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591838#comment-14591838 ]
Adrien Grand commented on LUCENE-6575: -------------------------------------- I don't think we should add this method to PhraseQuery. If only query parsers need to be able to update the slop of an existing PhraseQuery, we should put this utility method somewhere which is specific to query parsers. In general we try to have as little surface as we can in our public APIs such as queries, Document, IndexSearcher, etc. > Improve API of PhraseQuery.Builder > ---------------------------------- > > Key: LUCENE-6575 > URL: https://issues.apache.org/jira/browse/LUCENE-6575 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Cao Manh Dat > Priority: Minor > Attachments: LUCENE-6575.patch, LUCENE-6575.patch, LUCENE-6575.patch > > > From LUCENE-6531 > In current PhraseQuery.Builder API. User must retype field again and again : > {code} > PhraseQuery.Builder builder = new PhraseQuery.Builder(); > builder.add(new Term("lyrics", "when"), 1); > builder.add(new Term("lyrics", "believe"), 3); > {code} > Cleaner API : > {code} > PhraseQuery.Builder builder = new PhraseQuery.Builder("lyrics"); > builder.add("when", 1); > builder.add("believe", 3); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org