[
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600687#comment-14600687
]
David Smiley commented on LUCENE-6578:
--------------------------------------
I took a brief look. Wow this patch is big. But it contains a lot of
repetition, that will make maintenance harder. One type of repetition is the
Javadocs. If a superclass/interface defines a method, then put javadocs only
there and don't copy-paste to each implementing class (unless there's truly
something unique to say). The other type of repetition is the distance
algorithm between several added methods of most instances of any particular
shape instance. For example I see the same method with method calls changed
from "normalDistance" to "normalDistanceSquared" but otherwise appears
identical. Can you please think of a way to approach this with less repetition
and thus more maintainability? Also, a few of these added methods might have
suitable default implementations in a superclass, like
computeOutsideSquaredNormalDistance(Geopoint pt) to simply call by x,y,z.
> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
> Key: LUCENE-6578
> URL: https://issues.apache.org/jira/browse/LUCENE-6578
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6578.patch
>
>
> I've got an application that seems like it may need the ability to compute a
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a
> GeoShape. Adding this method to the interface, and corresponding
> implementations, would increase the utility of the package for ranking
> purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
