[ 
https://issues.apache.org/jira/browse/SOLR-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-7725:
--------------------------------
    Attachment: SOLR-7725.patch

Took the first test I could find and moved it to using MiniSolrCloudCluster. 
The test used to take approximately 45s on my system before but now takes 28s. 

I haven't looked into why we need - 

{{System.setProperty("solr.test.sys.prop2", "proptwo");}} etc but if the 
approach looks fine we can change the other tests as well. 

> Solr tests should have a easy way to not start up with the bootstrapped 
> collections
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-7725
>                 URL: https://issues.apache.org/jira/browse/SOLR-7725
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>         Attachments: SOLR-7725.patch
>
>
> Tests which want to run in its own collection and do not need the default 
> collection still extend AbstractFullDistribZkTestBase
> We are paying the penalty of creating these extra collections with 
> potentially more servers than required. This can add a few seconds to each 
> test at least. 
> I tried moving the test I wrote on SOLR-5750 to using a MiniSolrCloudCluster 
> and got a 10s improvement.  The downside is I can't use methods such as 
> {{getDoc()}} , {{waitForRecoveriesToFinish()}} since I am now extending 
> SolrTestCaseJ4.
> An easy solution right now is to move methods like waitForRecoveriesToFinish 
> to a util class and have all tests which don't rely on the default collection 
> or the control_collection to use MiniSolrCloudCluster. 
> A longer term solution would be to provide this from the test framework 
> itself.
> An easy way to check how many tests don't need the default collection is to 
> see which all tests are calling - {{waitForRecoveriesToFinish(String 
> collection, boolean verbose)}} I can see roughly ~25 test classes calling it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to