[ https://issues.apache.org/jira/browse/LUCENE-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604363#comment-14604363 ]
Michael McCandless commented on LUCENE-6547: -------------------------------------------- bq. Added geohash string utility methods to GeoUtils to support use-cases using geohash string representations (converts to/from geohash) Cool! But can we add tests for these new methods? bq. Updated randomized test to include larger ranges (this should include the occasional dateline wrapping but I'll add some randomization for explicit dateline wrap testing) Wait: these queries can't handle large ranges right? I.e. the query (and this test) can now take way too long to run? This is why we had to restrict the tested range before... Separately, I don't think this means testRandom will sometimes test the dateline ... it still has checks to swap lon0/lon1 when lon0 > lon1. I think we can keep the "tiny testing area", but just randomly locate it near the dateline some of the time, and then do the min/max swap "in reverse"? For now I put back the small testing area ... testing was sometimes taking forever ... I'll try to tweak the patch to make the randomized test more understandable. > Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries > ---------------------------------------------------------------------------- > > Key: LUCENE-6547 > URL: https://issues.apache.org/jira/browse/LUCENE-6547 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Nicholas Knize > Attachments: LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch, > LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch > > > The current GeoPointInBBoxQuery only supports bounding boxes that are within > the standard -180:180 longitudinal bounds. While its perfectly fine to > require users to split dateline crossing bounding boxes in two, > GeoPointDistanceQuery should support distance queries that cross the > dateline. Since morton encoding doesn't support unwinding this issue will > add dateline crossing to GeoPointInBBoxQuery and GeoPointDistanceQuery > classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org