[
https://issues.apache.org/jira/browse/LUCENE-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606403#comment-14606403
]
Erick Erickson commented on LUCENE-6514:
----------------------------------------
bq: I see a not uniform use of spaces across the already committed code as well
from trunk.
Which is unfortunate, but true. It's a continual battle to get formatting done
and there's code that has been checked in that doesn't conform to standards.
I try resist the temptation to reformat whole files as then looking at the
diffs is much harder. So basically I try to insure that code I change has been
reformatted (at least the changed parts).
If there's a really horrible file that you just can't _stand_ because the
formatting is so bad, then it's OK to reformat the entire file and check it in
_without_ changing any code and add a note like "reformat only, no code
changes". But practically I find this very rare.
FWIW
> 'ant idea' no longer includes code style settings
> -------------------------------------------------
>
> Key: LUCENE-6514
> URL: https://issues.apache.org/jira/browse/LUCENE-6514
> Project: Lucene - Core
> Issue Type: Bug
> Components: -tools
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Priority: Minor
> Fix For: 5.3
>
> Attachments: LUCENE-6514.patch
>
>
> Fairly recently, with modern versions of IntelliJ (14+ ?), code style
> settings are no longer included when you run {{ant idea}}, so you get the
> defaults (4 spaces per indent level rather than 2, etc.)
> The {{.idea/projectCodeStyle.xml}} file is still there, so something has
> changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
