[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990027#comment-12990027 ]
Uwe Schindler commented on LUCENE-2609: --------------------------------------- Hi Shai, patch looks fine (applies only to 3.x with Tortoise, I assume you used 3.x), with something minor not easy to fix: The JAR files' MANIFEST of the test-framework still contain the project name "-core" because <build-manifest> uses the ANT project name. To fix we need to add another parameter to build-manifest which is hairy, so I would leave that out for now. I would commit it, I tested almost every combination and my build-release script! Nice work! > Generate jar containing test classes. > ------------------------------------- > > Key: LUCENE-2609 > URL: https://issues.apache.org/jira/browse/LUCENE-2609 > Project: Lucene - Java > Issue Type: Improvement > Components: Build > Affects Versions: 3.0.2 > Reporter: Drew Farris > Assignee: Shai Erera > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, > LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, > LUCENE-2609.patch > > > The test classes are useful for writing unit tests for code external to the > Lucene project. It would be helpful to build a jar of these classes and > publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org