[
https://issues.apache.org/jira/browse/LUCENE-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610941#comment-14610941
]
Adrien Grand commented on LUCENE-6650:
--------------------------------------
Thanks David! This issue is mostly important for trunk indeed, but backporting
to 5.x and deprecating the old stuff would be nice too.
bq. on 5x SpatialStrategy.makeFilter can be deprecated (for back-compat)
+1 Maybe we could even make this method final and return a QueryWrapperFilter
around the result of makeQuery? Since QueryWrapperFilter rewrites to the
wrapped query and FilteredQuery rewrites to a BooleanQuery, this means that
running a FilteredQuery with the result of makeFilter or a BooleanQuery with a
FILTER clause with the result of makeQuery would do exactly the same thing.
I know that some spatial filters throw an exception when someone tries to pull
an iterator. I don't think a similar behaviour would be necessary anymore given
that we have tests that BooleanQuery takes advantage of approximations when
they are available, while FilteredQuery could still use an inefficient iterator
if you did not configure the appropriate FilterStrategy?
> Remove dependency of lucene/spatial on oal.search.Filter
> --------------------------------------------------------
>
> Key: LUCENE-6650
> URL: https://issues.apache.org/jira/browse/LUCENE-6650
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: David Smiley
>
> We should try to remove usage of oal.search.Filter in lucene/spatial. I gave
> it a try but this module makes non-trivial use of filters so I wouldn't mind
> some help here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
