[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615041#comment-14615041
]
Michael McCandless commented on LUCENE-6365:
--------------------------------------------
Ahh thanks for digging [~dawid.weiss] and [~markus_heiden].
[~markus_heiden] usually all that's necessary to reproduce a test is to
copy/past the exact text after "Reproduce with: ...", in this case:
{noformat}
ant test -Dtestcase=FiniteStringsIteratorTest
-Dtests.method=testRandomFiniteStrings1 -Dtests.seed=4A938C5F6E728DCC
-Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=es_CU
-Dtests.timezone=America/Porto_Velho -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
{noformat}
That usually reproduces the failure, though sometimes you'll need the exact JVM
version, added JVM flags, etc.
I agree it should not be this iterator's job to deal with duplicates: I think
if you pass a non-minimal automaton to it, it's fair game for it to return dups
... so this is a test bug.
> Optimized iteration of finite strings
> -------------------------------------
>
> Key: LUCENE-6365
> URL: https://issues.apache.org/jira/browse/LUCENE-6365
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 5.0
> Reporter: Markus Heiden
> Priority: Minor
> Labels: patch, performance
> Fix For: 5.3, Trunk
>
> Attachments: FiniteStrings_noreuse.patch, FiniteStrings_reuse.patch,
> LUCENE-6365.patch
>
>
> Replaced Operations.getFiniteStrings() by an optimized FiniteStringIterator.
> Benefits:
> Avoid huge hash set of finite strings.
> Avoid massive object/array creation during processing.
> "Downside":
> Iteration order changed, so when iterating with a limit, the result may
> differ slightly. Old: emit current node, if accept / recurse. New: recurse /
> emit current node, if accept.
> The old method Operations.getFiniteStrings() still exists, because it eases
> the tests. It is now implemented by use of the new FiniteStringIterator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
