[ 
https://issues.apache.org/jira/browse/LUCENE-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622271#comment-14622271
 ] 

Terry Smith commented on LUCENE-6661:
-------------------------------------

I agree that we shouldn't base API's off of already hacking solutions.

I'm going to play with your suggestion a little more and see how it pans out 
for my usecases, will report back.

The ring buffer frequency for non-cacheable queries issue is interesting. If in 
some obscure but easy to understand scenario half of my queries are good cache 
candidates but the other half are never to be cached (using the 
Weight.getQuery() equals busting method) then the ring buffer will be a lot 
less effective at finding new cache candidates purely based on the churn of 
never-to-be-cached queries. Still, I can see why that might also be a good 
thing, it all depends on your definition of frequently used.

Where would be the best place to expand this discussion to include score based 
caching? A new Jira, one of the mailing lists?




> Allow queries to opt out of caching
> -----------------------------------
>
>                 Key: LUCENE-6661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6661
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 5.2
>            Reporter: Terry Smith
>            Priority: Minor
>         Attachments: LUCENE-6661.patch
>
>
> Some queries have out-of-band dependencies that make them incompatible with 
> caching, it'd be great if they could opt out of the new fancy query/filter 
> cache in IndexSearcher.
> This affects DrillSidewaysQuery and any user-provided custom Query 
> implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to