[
https://issues.apache.org/jira/browse/SOLR-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634841#comment-14634841
]
Anshum Gupta commented on SOLR-7756:
------------------------------------
Thanks Varun. Looks good. Here are a few suggestions:
* You should reset solr.test.sys.* system properties during teardown.
* It'd be good to refactor the test a little bit (nothing pressing)
* Do we really need 3 shards in the test? I think we can do with just 2 and
save time for the test run.
There's also a bunch of formatting changes that's a part of the patch. I just
glanced through it, but in case it's something that's not required, it'd be
good to not refactor those.
P.S: If the current formatting is screwed up, by all means clean it up.
> NPE in ExactStatsCache when a term doesn't exist on a shard
> -----------------------------------------------------------
>
> Key: SOLR-7756
> URL: https://issues.apache.org/jira/browse/SOLR-7756
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Fix For: 5.3
>
> Attachments: SOLR-7756.patch, SOLR-7756.patch, SOLR-7756.patch,
> SOLR-7756.patch
>
>
> If a term doesn't exist on a shard {{ExactStatsCache#getPerShardTermStats}}
> throws an NullPointerException.
> Attaching a test and a patch shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
