[ 
https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647690#comment-14647690
 ] 

Terry Smith commented on LUCENE-6531:
-------------------------------------

[~jpountz] The PhraseQuery.Builder setter methods are all void, where as the 
ones for BooleanQuery and BlendedTermQuery return the Builder itself.

Can the set/add methods on PhraseQuery.Builder return this to make the various 
Query builders consistent with each other?


> Make PhraseQuery immutable
> --------------------------
>
>                 Key: LUCENE-6531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6531
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 5.3, 6.0
>
>         Attachments: LUCENE-6531.patch, LUCENE-6531.patch
>
>
> Mutable queries are an issue for automatic filter caching since modifying a 
> query after it has been put into the cache will corrupt the cache. We should 
> make all queries immutable (up to the boost) to avoid this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to