[
https://issues.apache.org/jira/browse/LUCENE-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651840#comment-14651840
]
ASF subversion and git services commented on LUCENE-6691:
---------------------------------------------------------
Commit 1693897 from [~cpoerschke] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1693897 ]
LUCENE-6691: SortingMergePolicy.(getSortDescription|isSorted) now considers
FilterLeafReader instances. EarlyTerminatingSortingCollector.terminatedEarly
accessor added. TestEarlyTerminatingSortingCollector.testTerminatedEarly test
added.
> tweak SortingMergePolicy.getSortDescription
> -------------------------------------------
>
> Key: LUCENE-6691
> URL: https://issues.apache.org/jira/browse/LUCENE-6691
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> Building tests for SOLR-5730 identified that early termination can be omitted
> for sorted segments because the {{LeafReader}} concerned is not a
> {{SegmentReader}} - github pull request to illustrate to follow:
> * the {{TestEarlyTerminatingSortingCollector.testTerminatedEarly}} test uses
> a wrapped reader in the same way as {{SolrIndexSearcher}}
> * the {{SortingMergePolicy.getSortDescription}} change (assuming it is a
> valid change to make) fixes that particular test only
> * {{ExitableDirectoryReader}} and {{UninvertingReader}} wrap could perhaps
> also be added in {{LuceneTestCase.wrapReader}} ?
> LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead."
> also concerns SortingMergePolicy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
