Robert Muir wrote: > > On Tue, Feb 8, 2011 at 9:12 AM, David Smiley (@MITRE.org) > <dsmi...@mitre.org> wrote: > >> I'm skeptical that whatever the difference is is relevant in the scheme >> of >> things. The cost to keeping it is introducing confusion on users, and >> more >> code to maintain. >> > > its pretty significant. charfilters are not reusable, and box every > character and lookup out of a hashmap (i made a patch to fix the > reusability, but no one has commented) : > https://issues.apache.org/jira/browse/LUCENE-2788 > > asciifoldingfilter does a huge switch (which still isnt optimal), but > its way way faster than mappingcharfilter, especially since its a > no-op for chars < 0x7F. >
Well then I see a path forward to speed up MappingCharFilter substantially. There's your LUCENE-2788, and then you could easily add the same no-op optimization for the smallest char value in the HashMap. ----- Author: https://www.packtpub.com/solr-1-4-enterprise-search-server/book -- View this message in context: http://lucene.472066.n3.nabble.com/Should-ASCIIFoldingFilter-be-deprecated-tp2448919p2451800.html Sent from the Solr - Dev mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
