[
https://issues.apache.org/jira/browse/SOLR-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653962#comment-14653962
]
Shalin Shekhar Mangar commented on SOLR-5756:
---------------------------------------------
Thanks Scott. A few more comments:
# Need a null check for "children" in ZkStateReader.refreshLazyCollections()
# I don't see where the clusterState object in ZkStateReader is initialized?
The createClusterStateWatchersAndUpdate() method just calls constructState(new
HashSet<>(liveNodes)); but doesn't set its return value to the clusterState
variable.
# Nit-pick: It looks like the code for updating live nodes in
ZkStateReader.createClusterStateWatchersAndUpdate() can use updateLiveNodes()
directly (with a watcher)?
# Nit-pick: There was a lot of controversy on naming collections as "external"
when this was originally implemented in SOLR-5473. In the interest of avoiding
controversy and bike-shedding, can you rename "external" to "stateFormat2"
wherever possible? e.g. "externalCollectionExists" to "isStateFormat2()" etc.
I think now we are in a position to write a test which:
# Creates a collection in shared cluster state
# Creates a state.json for the same collection
# Mutates state in shared cluster state and asserts that those changes are not
visible in ZkStateReader
# Deletes old cluster state and ensures that everything still works fine.
> A utility API to move collections from internal to external
> -----------------------------------------------------------
>
> Key: SOLR-5756
> URL: https://issues.apache.org/jira/browse/SOLR-5756
> Project: Solr
> Issue Type: Bug
> Reporter: Noble Paul
> Assignee: Shalin Shekhar Mangar
> Attachments: SOLR-5756-trunk.patch, SOLR-5756-trunk.patch,
> SOLR-5756-vs-5.2.1.patch
>
>
> SOLR-5473 allows creation of collection with state stored outside of
> clusterstate.json. We would need an API to move existing 'internal'
> collections outside
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
