[
https://issues.apache.org/jira/browse/SOLR-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654747#comment-14654747
]
Ramkumar Aiyengar commented on SOLR-7860:
-----------------------------------------
This is a good start Ishan! There's also IndexFetcher which has it's own http
client..
There is one question still here which I am in two minds about myself. One
thing we do get by separate select and update httpclients is that you can
configure limits/parallelism on each one separately. By extension, should we be
aiming to consolidate the clients or just standardizing clients, for example,
by just providing a "client factory" which can provide different clients for
different kinds of operations within Solr, and have an unified configuration?
So, the configuration describes different clients for different purposes with
different tunables (with defaults obviously), and we instantiate a factory with
that config, which can then hand out a client for anything which needs one for
one of these purposes?
> Standardize use of HttpSolrClients in Solr
> ------------------------------------------
>
> Key: SOLR-7860
> URL: https://issues.apache.org/jira/browse/SOLR-7860
> Project: Solr
> Issue Type: Improvement
> Reporter: Ramkumar Aiyengar
> Priority: Minor
> Attachments: SOLR-7860.patch
>
>
> {{HttpShardHandlerFactory}} and {{UpdateShardHandler}} already provide two
> places where one can get {{HttpSolrClient}}s with timeouts set up properly
> etc., but there are lots of miscellaneous places which instantiate their own,
> with hardcoded timeouts. These are just waiting for some environment to
> realize the timeouts are not suitable, and not configurable as well. We
> should standardize this (anyone knows why there two to begin with?), ideally
> this hardcoding shouldn't exist at all..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
