[ 
https://issues.apache.org/jira/browse/LUCENE-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655259#comment-14655259
 ] 

Christine Poerschke commented on LUCENE-6571:
---------------------------------------------

With respect to the {{LiveIndexWriterConfig.java:386}} warning, we have 
currently

IndexWriterConfig.java
{code}
public final class IndexWriterConfig extends LiveIndexWriterConfig {
  ...
  IndexWriterConfig setIndexingChain(IndexingChain indexingChain) {
    if (indexingChain == null) {
      throw new IllegalArgumentException("indexingChain must not be null");
    }
    this.indexingChain = indexingChain;
    return this;
  }

  @Override
  IndexingChain getIndexingChain() {
    return indexingChain;
  }
{code}

LiveIndexWriterConfig.java
{code}
public class LiveIndexWriterConfig {
  ...
  protected volatile IndexingChain indexingChain;
  /**
   * Returns the indexing chain set on
   * {@link IndexWriterConfig#setIndexingChain(IndexingChain)}.
   */
  IndexingChain getIndexingChain() {
    return indexingChain;
  }
{code}

i.e. {{@link IndexWriterConfig#setIndexingChain}} in the base class references 
a non-public function in the derived class.

I wonder if the {{@Override getIndexingChain()}} function in the derived class 
could be removed and {{setIndexingChain}} be relocated to the base class? And 
might {{indexingChain}} be made {{private}} instead of {{protected}} then also?

> Javadoc error when run in private access level
> ----------------------------------------------
>
>                 Key: LUCENE-6571
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6571
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 5.2
>            Reporter: Cao Manh Dat
>            Assignee: Christine Poerschke
>            Priority: Trivial
>         Attachments: LUCENE-6571.patch
>
>
> Javadoc error when run in private access level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to