[ 
https://issues.apache.org/jira/browse/SOLR-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679779#comment-14679779
 ] 

Jan Høydahl commented on SOLR-7888:
-----------------------------------

Will let others chime in on the param names too. Which one do you like the best?
* {{suggest.contextFilterQuery}}
* {{suggest.contextQ}}
* {{suggest.fq}}
* {{suggest.context.fq}}

The {{suggest.fq}} variant would be in line with filters for main query, but 
does not indicate that it is for context field only, so people could 
misunderstand and try filter for other fields.

Another issue is this line in the patch
{code}
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST,"Context Filtering 
Query not yet supported by "+lookup.getClass());
{code}
Solr supports running multiple suggesters in parallel on one call. Should we 
require that if you want to use the context filtering, all suggesters must 
support it (like in current patch) or should we fallback to not filtering for 
the other suggesters. I guess there are use cases that would want both 
behaviors...

> Make Lucene's AnalyzingInfixSuggester.lookup() method that takes a 
> BooleanQuery filter parameter available in Solr
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7888
>                 URL: https://issues.apache.org/jira/browse/SOLR-7888
>             Project: Solr
>          Issue Type: New Feature
>          Components: Suggester
>    Affects Versions: 5.2.1
>            Reporter: Arcadius Ahouansou
>            Assignee: Jan Høydahl
>             Fix For: 5.4
>
>         Attachments: SOLR-7888.patch
>
>
>  LUCENE-6464 has introduced a very flexible lookup method that takes as 
> parameter a BooleanQuery that is used for filtering results.
> This ticket is to expose that method to Solr.
> This would allow user to do:
> {code}
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:tennis
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:golf
>  AND contexts:football
> {code}
> etc
> Given that the context filtering in currently only implemented by the 
> {code}AnalyzingInfixSuggester{code} and by the 
> {code}BlendedInfixSuggester{code}, this initial implementation will support 
> only these 2 lookup implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to