[ 
https://issues.apache.org/jira/browse/LUCENE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692467#comment-14692467
 ] 

Karl Wright commented on LUCENE-6699:
-------------------------------------

Introducing a stray dependency outside of spatial3d seems like it would make 
maintenance *more* of a nightmare rather than less.  Objects representing 
abstractions don't necessarily make things more messy either. Static methods 
are fine but when you have lack of any significant data abstraction you have a 
very messy picture indeed.  And I don't recall you complaining over the last 
seven months about geo3d's architecture and organization, so I presume that it 
was acceptable to you.

As for duping code, I guess it's all part of the bigger question is whether 
geo3d should remain separable from Lucene.  For me, Geo3d at the moment needs 
to remain as a working whole without dependencies on the rest of Lucene, 
because otherwise it will not be usable in my employer's environment.  That may 
change in the long run, after there's a public release of this stuff and we 
upgrade to it, but for now it would just make things much more complicated for 
me.

> Integrate lat/lon BKD and spatial3d
> -----------------------------------
>
>                 Key: LUCENE-6699
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6699
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>         Attachments: Geo3DPacking.java, LUCENE-6699.patch, LUCENE-6699.patch, 
> LUCENE-6699.patch, LUCENE-6699.patch
>
>
> I'm opening this for discussion, because I'm not yet sure how to do
> this integration, because of my ignorance about spatial in general and
> spatial3d in particular :)
> Our BKD tree impl is very fast at doing lat/lon shape intersection
> (bbox, polygon, soon distance: LUCENE-6698) against previously indexed
> points.
> I think to integrate with spatial3d, we would first need to record
> lat/lon/z into doc values.  Somewhere I saw discussion about how we
> could stuff all 3 into a single long value with acceptable precision
> loss?  Or, we could use BinaryDocValues?  We need all 3 dims available
> to do the fast per-hit query time filtering.
> But, second: what do we index into the BKD tree?  Can we "just" index
> earth surface lat/lon, and then at query time is spatial3d able to
> give me an enclosing "surface lat/lon" bbox for a 3d shape?  Or
> ... must we index all 3 dimensions into the BKD tree (seems like this
> could be somewhat wasteful)?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to