[
https://issues.apache.org/jira/browse/SOLR-7917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693992#comment-14693992
]
Yonik Seeley commented on SOLR-7917:
------------------------------------
OK, whew, I think I found it... false alarm.
The code in question was only being hit during warming. So invalid DocSet
creation would cause the test to fail, but when I added assertions to catch the
issue, it would cause the warming to fail (and we only log exceptions,
including assertions during warming since they don't belong to any user
request). The failed warming actually helped the test pass (because there was
not a bad DocSet being cached).
I guess one takeaway would be that perhaps we want a way to fail tests if there
were any failures during warming.
> test framework doesn't necessarily fail when it should
> ------------------------------------------------------
>
> Key: SOLR-7917
> URL: https://issues.apache.org/jira/browse/SOLR-7917
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.2, Trunk
> Reporter: Yonik Seeley
> Priority: Blocker
>
> I was trying to track down a tricky bug, but when I added assertions to
> narrow it down, the test started passing!
> These were assertions that were hit within the context of a search, not
> assertions within the test class itself, so this is probably an issue with
> the solr test harness.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
