[
https://issues.apache.org/jira/browse/SOLR-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-6629:
----------------------------------------
Attachment: SOLR-6629.patch
Patch wasn't applying cleanly to trunk so I updated it. This one should apply
cleanly.
Thanks Scott. Overall looks great to me!
A few comments:
# In ZkStateReader#refreshCollectionList, how do you ensure that a
stateFormat=1 collection which is not interesting to us, isn't put into the
lazyCollectionStates map? Or does it not matter because constructState() will
always give priority to the ones in shared cluster state?
# nit - The variables in ZkStateWriter "wasPreviouslyState1" and
"isCurrentlyState1" were confusing me so I renamed them to
"wasPreviouslyStateFormat1" and "isCurrentlyStateFormat1"
> Watch /collections zk node on all nodes
> ---------------------------------------
>
> Key: SOLR-6629
> URL: https://issues.apache.org/jira/browse/SOLR-6629
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Noble Paul
> Fix For: Trunk
>
> Attachments: SOLR-6629.patch, SOLR-6629.patch
>
>
> The main clusterstate.json is refreshed/used as a poor substitute for
> informing all nodes about new or deleted collections even when the collection
> being created or deleted has state format > 1. When we move away from state
> format 1 then we should do away with this workaround and start watching the
> /collections zk node on all nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
