[
https://issues.apache.org/jira/browse/SOLR-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man reassigned SOLR-7984:
------------------------------
Assignee: Noble Paul
this was the change made by [~noble.paul] in r1665295 for SOLR-7073 - I see no
rationale for the restructing of the code so that the warning is conditionally
nested like this, but assigning to noble to sanity check and clarify what his
goal was here...
{noformat}
+ if(!handlers.alias( "/select","")){
+ if(!handlers.alias( "standard","")){
+ log.warn("no default request handler is registered (either '/select'
or 'standard')");
}
}
- if(get("") == null) register("", get("/select"));//defacto default handler
- if(get("") == null) register("", get("standard"));//old default handler
name; TODO remove?
- if(get("") == null)
- log.warn("no default request handler is registered (either '/select' or
'standard')");
{noformat}
> totally bogus and missleading "no default request handler is registered"
> logged by RequestHandlers
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-7984
> URL: https://issues.apache.org/jira/browse/SOLR-7984
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Noble Paul
>
> As noted on the user list by Scott Hollenbeck the following warning can be
> logged by solr...
> bq. no default request handler is registered (either '/select' or 'standard')
> ...even if there is both a handler named "standard" and a handler (in his
> case named "pinkPony") defined as default="true".
> The code in question appears to be total nonsense...
> {code}
> if(!handlers.alias( "/select","")){
> if(!handlers.alias( "standard","")){
> log.warn("no default request handler is registered (either '/select'
> or 'standard')");
> }
> }
> {code}
> * PluginBag.alias is not documented, but appears to be a mutating operation
> that _adds_ an alias if and only if the first arg is aname of something that
> exists, and the second arg is a name that does not already exist -- returning
> true if the alias is added
> * if an alias already exists with the (default) name "" (which
> initHandlersFromConfig takes care of registring before this code) then
> neither of these can be made the new default.
> * just because neither of these aren't made the default here, doesn't mean
> there isn't already a default handler -- it actually means the exact oposite
> * if the goal was to log an error when there is no default, then that should
> have just been checked directly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
