[
https://issues.apache.org/jira/browse/LUCENE-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717431#comment-14717431
]
Michael McCandless commented on LUCENE-6768:
--------------------------------------------
+1, except can we keep the local var {{sortFieldCount}} just set it to e.g.
{{comparators.length}} instead of the confusing {{compIDXEnd+1}}?
> AbstractFirstPassGroupingCollector.groupSort private member is not needed
> -------------------------------------------------------------------------
>
> Key: LUCENE-6768
> URL: https://issues.apache.org/jira/browse/LUCENE-6768
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Attachments: LUCENE-6768.patch
>
>
> patch with proposed change to follow.
> (SOLR-2072 could result in {{AbstractFirstPassGroupingCollector}} changes
> also but from glancing through the patches the {{groupSort}} member would
> still not be needed (but could of course be added back if/when needed))
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
