[ 
https://issues.apache.org/jira/browse/SOLR-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Grama updated SOLR-7690:
-------------------------------
    Attachment: SOLR-7690.patch

In the patch can be found the SolrDispatchFilterOverrideTest class.

Unfortunately, I can't seem to find a way how to call 
HttpSolrCall#sendError(int, String) method.

In HttpSolrCall.java line 409-412 there is the check :  
{code}
if (solrDispatchFilter.abortErrorMessage != null) {
      sendError(500, solrDispatchFilter.abortErrorMessage);
      return RETURN;
}
{code}
but the field abortErrorMessage is never set in SolrDispatchFilter class. 

The method HttpSolrCall#sendError(int, String)  is also used in 
HttpSolrCall#sendError(Throwable) , but i don't see an easy way to simulate a 
situation generating an exception within the previously mentioned method call.

> Add a test to assert that request dispatcher functions can be overridden
> ------------------------------------------------------------------------
>
>                 Key: SOLR-7690
>                 URL: https://issues.apache.org/jira/browse/SOLR-7690
>             Project: Solr
>          Issue Type: Test
>            Reporter: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: Trunk, 5.4
>
>         Attachments: SOLR-7690.patch
>
>
> It should be possible for basic functions of the solr request dispatcher to 
> be overridden e.g.
> {code}
> protected void execute(SolrQueryResponse rsp)
> {code}
> and
> {code}
> protected void sendError(int code, String message) throws IOException {
> {code}
> In Solr 5.2, SOLR-7484 broke this functionality and was fixed in 5.2.1 by 
> SOLR-7623. We should add a test which asserts this feature so that it is not 
> accidentally broken again in future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to