[
https://issues.apache.org/jira/browse/SOLR-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725903#comment-14725903
]
Scott Blum commented on SOLR-7956:
----------------------------------
[[email protected]] LGTM, thanks!
One question about:
https://svn.apache.org/viewvc/lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/CommitTracker.java?r1=1700188&r2=1700187&pathrev=1700188
I don't remember why anymore, but I may have needed to use
`ExecutorUtil.shutdownAndAwaitTermination(scheduler);` locally when I was
testing this. Curious if you have concrete reasons for preferring one or the
other here.
> There are interrupts on shutdown in places that can cause
> ChannelAlreadyClosed exceptions which prevents proper closing of transaction
> logs.
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-7956
> URL: https://issues.apache.org/jira/browse/SOLR-7956
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: Trunk, 5.4
>
> Attachments: SOLR-7956-commit-tracker.patch, SOLR-7956.patch,
> SOLR-7956.patch, SOLR-7956.patch
>
>
> Found this while beast testing HttpPartitionTest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
