[ 
https://issues.apache.org/jira/browse/SOLR-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gunnlaugur Thor Briem updated SOLR-2367:
----------------------------------------

    Attachment: SOLR-2367-log-exceptions-through-SolrException.patch

Here goes the remaining 20% — I'm attaching 
SOLR-2367-log-exceptions-through-SolrException.patch which makes 
{{DataImportHandler}} log exceptions through {{SolrException.log()}} instead of 
directly into the logger. This way the exception-ignoring mechanism gets a say 
in matters. Test output is nice and clean now. I addressed only those logger 
calls that were emitting exceptions in unit test runs.

Note: this does *not* require {{DataImportHandlerException}} to extend 
{{SolrException}}, so the earlier SOLR-2367-extend-SolrException.patch is not 
needed. (Might still be worthwhile, I don't know — but not needed for this fix).

> DataImportHandler unit tests are very noisy
> -------------------------------------------
>
>                 Key: SOLR-2367
>                 URL: https://issues.apache.org/jira/browse/SOLR-2367
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build, contrib - DataImportHandler
>            Reporter: Gunnlaugur Thor Briem
>            Assignee: Robert Muir
>            Priority: Trivial
>         Attachments: SOLR-2367-extend-SolrException.patch, 
> SOLR-2367-log-exceptions-through-SolrException.patch, SOLR-2367.patch, 
> SOLR-2367.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Running DataImportHandler unit tests emits a lot of console noise, mainly 
> stacktraces because dataimport.properties can't be written. This makes it 
> hard to scan the output for useful information.
> I'm attaching a patch to get rid of most of the noise by creating the conf 
> directory before test runs so that the properties file write doesn't fail.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to