[
https://issues.apache.org/jira/browse/LUCENE-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736643#comment-14736643
]
Robert Muir commented on LUCENE-6786:
-------------------------------------
Nice cleanup: +1
> Remove IndexFileDeleter.refresh(String)
> ---------------------------------------
>
> Key: LUCENE-6786
> URL: https://issues.apache.org/jira/browse/LUCENE-6786
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: Trunk, 5.4
>
> Attachments: LUCENE-6786.patch
>
>
> Today IW has try/finally around places (flush, merge) that write
> per-segment files and on exception uses IFD.refresh(String) to remove
> any newly created but now unreferenced files.
> But, since merge exceptions are now tragic, and IFD.refresh() (not
> taking a segment name) will be called, doing the same thing, I think
> it's safe to remove the per-segment refresh.
> This makes IW a little bit simpler ... and it means at least one fewer
> {{Directory.listAll}} while handling merge exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
