[
https://issues.apache.org/jira/browse/LUCENE-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739636#comment-14739636
]
Karl Wright edited comment on LUCENE-6797 at 9/10/15 9:29 PM:
--------------------------------------------------------------
[~mikemccand] This patch performs the necessary class rearrangement, but
doesn't handle the degenerate cases properly yet.
Please note that I *moved* the GeoCircle.java class to GeoStandardCircle.java,
and then created a new interface called GeoCircle.java. The patch may not
therefore apply happily. I've also left a "nocommit" in the GeoCircleFactory
class that will need to be addressed. But that is straightforward, and for now
we can actually just go ahead and commit, I think, since any improvements will
simply make the method "makeGeoCircle()" handle more cases.
There should be no functional changes, just structural ones. Any questions
please feel free to ask.
was (Author: [email protected]):
[~mikemccand] This patch performs the necessary class rearrangement, but
doesn't handle the degenerate cases properly yet.
Please note that I *moved* the GeoCircle.java class to GeoStandardCircle.java,
and then created a new interface called GeoCircle.java. The patch may not
therefore apply happily. I've also left a "nocommit" in the GeoCircleFactory
class that will need to be addressed. But that is straightforward, and for now
we can actually just go ahead and commit, I think, since any improvements will
simply make the method "makeGeoCircle()" handle more cases.
There should be no functional changes, just structural ones. Any questions
please feel free to ask.
If
> Geo3d circle construction could benefit from its own factory
> ------------------------------------------------------------
>
> Key: LUCENE-6797
> URL: https://issues.apache.org/jira/browse/LUCENE-6797
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6797.patch
>
>
> GeoCircles need special handling for whole-world situations and for single
> point situations. It would be better to have a factory that constructed
> appropriate instance types based on the parameters than try to fold
> everything into one class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
