[
https://issues.apache.org/jira/browse/SOLR-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-8026:
-----------------------------------
Attachment: SOLR-8026.patch
the test relied on fractional scores coming from any query to distinguish
between scoring and nonscoring join, which has 1.0 score hardcoded.
After the boosting refactoring, trivial term query returns evenly normalized
score 1.0 (what a breakthrough!) that sadly made both joins indistinguishable.
Here is the patch, which adds a weird term to skew weight normalization. Thus,
"from" query is changed from {{match_s:c}} to {{match_s:c
match_s:not_1_0_score_after_weight_normalization}}
Test works again! (until nonexistent terms are ignored during normalization)
Please review
> DistribJoinFromCollectionTest test failures
> -------------------------------------------
>
> Key: SOLR-8026
> URL: https://issues.apache.org/jira/browse/SOLR-8026
> Project: Solr
> Issue Type: Bug
> Affects Versions: Trunk
> Reporter: Joel Bernstein
> Assignee: Mikhail Khludnev
> Attachments: SOLR-8026.patch, SOLR-8026.patch
>
>
> Trunk DistribJoinFromCollectionTest is failing for me locally and appears be
> failing on jenkins as well. Here is the error from my local machine.
> [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=DistribJoinFromCollectionTest -Dtests.method=test
> -Dtests.seed=5C8C1B007BE0841E -Dtests.slow=true -Dtests.locale=it
> -Dtests.timezone=Australia/Melbourne -Dtests.asserts=true
> -Dtests.file.encoding=ISO-8859-1
> [junit4] FAILURE 44.4s | DistribJoinFromCollectionTest.test <<<
> [junit4] > Throwable #1: java.lang.AssertionError:
> [junit4] > Expected: not "1.0"
> [junit4] > got: "1.0"
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([5C8C1B007BE0841E:D4D824DAD51CE9E6]:0)
> [junit4] > at
> org.apache.solr.cloud.DistribJoinFromCollectionTest.assertScore(DistribJoinFromCollectionTest.java:170)
> [junit4] > at
> org.apache.solr.cloud.DistribJoinFromCollectionTest.testJoins(DistribJoinFromCollectionTest.java:132)
> [junit4] > at
> org.apache.solr.cloud.DistribJoinFromCollectionTest.test(DistribJoinFromCollectionTest.java:100)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:963)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:938)
> [junit4] > at java.lang.Thread.run(Thread.java:745)
> [junit4] 2> 44372 INFO
> (SUITE-DistribJoinFromCollectionTest-seed#[5C8C1B007BE0841E]-worker)
> [n:127.0.0.1:59399_ c:from_1x2 s:shard1 r:core_node2
> x:from_1x2_shard1_replica2] o.a.s.SolrTestCaseJ4 ###deleteCore
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
