[
https://issues.apache.org/jira/browse/SOLR-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744939#comment-14744939
]
Arcadius Ahouansou commented on SOLR-7888:
------------------------------------------
Hello [~janhoy]
Thank you for uploading the updated version.
I am pretty happy with your changes and I would suggest we go ahead with that.
There are few minor changes that are needed:
- {code}- SuggesterResult suggesterResult =
suggester.getSuggestions(options);
+ SuggesterResult suggesterResult = suggester.getSuggestions(options,
rb.req);{code}
The additional param {{rb.req}} was needed only for SOLR-7963, so it can be
removed here and in all subsequent methods.
- As we no longer rely on the schema, maybe we should review/rename the test
{{testContextFilterUsesAnalyzerFromSchema()}}?
I am not quite sure whether the {{* Clone of CONTEXTS_FIELD_NAME in
AnalyzingInfixSuggester}} is an excellent idea, but that it very minor.
So, please let's go ahead with this.
Thank you very much.
I will address your comments regarding SOLR-7963 later on.
> Make Lucene's AnalyzingInfixSuggester.lookup() method that takes a
> BooleanQuery filter parameter available in Solr
> ------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-7888
> URL: https://issues.apache.org/jira/browse/SOLR-7888
> Project: Solr
> Issue Type: New Feature
> Components: Suggester
> Affects Versions: 5.2.1
> Reporter: Arcadius Ahouansou
> Assignee: Jan Høydahl
> Fix For: 5.4
>
> Attachments: SOLR-7888-7963.patch, SOLR-7888.patch
>
>
> LUCENE-6464 has introduced a very flexible lookup method that takes as
> parameter a BooleanQuery that is used for filtering results.
> This ticket is to expose that method to Solr.
> This would allow user to do:
> {code}
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:tennis
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:golf
> AND contexts:football
> {code}
> etc
> Given that the context filtering in currently only implemented by the
> {code}AnalyzingInfixSuggester{code} and by the
> {code}BlendedInfixSuggester{code}, this initial implementation will support
> only these 2 lookup implementations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
