[
https://issues.apache.org/jira/browse/LUCENE-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906093#comment-14906093
]
Michael McCandless commented on LUCENE-6813:
--------------------------------------------
bq. Hmm... I don't like the move of defaultTempDir() to a static initializer
OK ... if there is a cleaner way I would love to do that instead.
bq. Wouldn't it be possible to set the java.io.tmpdir property to a path that
resolves to mockfs instead?
I don't know enough about mockfs to know if this is possible :) I thought we
must use the {{Path}} we had set up (backed by the mock {{FileSystem}} we
created) ... but maybe there is a way to "install" the mock filesystem
differently?
I do think it's really useful to have {{OfflineSorter}} use our mock
filesystems: it caught the bug in {{RangeTreeWriter}}...
> OfflineSorter.sort shouldn't remove the output Path up front
> ------------------------------------------------------------
>
> Key: LUCENE-6813
> URL: https://issues.apache.org/jira/browse/LUCENE-6813
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: Trunk, 5.4
>
> Attachments: LUCENE-6813.patch, LUCENE-6813.patch
>
>
> The new BKD tree classes, and NumericRangeTree (just a 1D BKD tree),
> make heavy use of OfflineSorter to build their data structures at
> indexing time when the number of indexed documents is biggish.
> But when I was first building them (LUCENE-6477), I hit a thread
> safety issue in OfflineSorter, and at that time I just worked around
> it by creating my own private temp directory each time I need to write
> a BKD tree.
> This workaround is sort of messy, and it causes problems with "pending
> delete" files on Windows when we try to remove that temp directory,
> causing test failures like
> http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Windows/5149/
> I think instead we should fix the root cause ... i.e. make
> OfflineSorter thread safe. It looks like it's simple...
> Separately I'd like to somehow fix these BKD tests to catch any leaked
> file handles ... I'm not sure they are today.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
