[
https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997412#comment-12997412
]
Mark Miller commented on SOLR-1226:
-----------------------------------
bq. So this hasn't been committed in 1.5+ years because I didn't write a unit
test?
More likely because the DIH authors have not been around/active for some time.
One of them is an assignee on this issue. I don't use DIH (like many of the
other active committers), and I am not too comfortably changing it. The state
of it's tests do not look good as is - last I looked, there is not much testing
going on.
> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
> Key: SOLR-1226
> URL: https://issues.apache.org/jira/browse/SOLR-1226
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Fix For: Next
>
> Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file
> is. if it is not a URL, what it should do is attempt to resolve it from
> Solr's configuration via SolrCore.getREsourceLoader(). I have attached a
> patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was
> not certain that XPathEntityProcessor needs to be thread-safe or not. So
> just in case I cached the XSLT Transformer in a thread-safe manner using a
> ThreadLocal. If DIH committers know that it doesn't have to be thread-safe
> then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
