[
https://issues.apache.org/jira/browse/LUCENE-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936669#comment-14936669
]
Adrien Grand commented on LUCENE-6650:
--------------------------------------
bq. I substituted BooleanClause.Occur.FILTER instead of MUST through I'm not
sure if it matters?
It should be equivalent.
The patch looks good to me overall, it feels cleaner to me that makeQuery and
makeFilter were merged to a single method that has a two-phase iterator. The
one thing that feels awkward to me is this topAcceptDocs which is top-level to
the reader, while everywhere else we work with per-segment data-structures?
> Remove dependency of lucene/spatial on oal.search.Filter
> --------------------------------------------------------
>
> Key: LUCENE-6650
> URL: https://issues.apache.org/jira/browse/LUCENE-6650
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: David Smiley
> Attachments: LUCENE-6650.patch, LUCENE-6650.patch
>
>
> We should try to remove usage of oal.search.Filter in lucene/spatial. I gave
> it a try but this module makes non-trivial use of filters so I wouldn't mind
> some help here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
