[
https://issues.apache.org/jira/browse/SOLR-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949158#comment-14949158
]
Mark Miller commented on SOLR-8130:
-----------------------------------
I'll commit this shortly, [~mdrob] has already taken a look at it for me and
pointed out I was missing passing a 'true' param on checking if we were in safe
mode. Mistranslation when taking it from reflection compatibility code.
I've also heavily tested manually entering and exiting safe mode pretty
heavily. It's much more difficult to simulate a natural safe mode situation.
Given Hbase uses the code and has for a long time and the difference in using a
proper (though odd), client side API (unlike the current method that depends on
catching exceptions passed through a remote class), we can expect that if it
works for manual safe mode, it will work for naturally entered safe mode.
> Solr's hdfs safe mode detection does not catch all cases of being in safe
> mode.
> -------------------------------------------------------------------------------
>
> Key: SOLR-8130
> URL: https://issues.apache.org/jira/browse/SOLR-8130
> Project: Solr
> Issue Type: Bug
> Components: hdfs
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8130.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
