[ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967275#comment-14967275 ]
David Smiley commented on LUCENE-6845: -------------------------------------- bq. we already changed the Spans interface in 5.3 by adding Spans.collect(), so users upgrading from 5.2 from 5.3 would have had to recompile I don't see why recompiling would be needed if you merely consume a Spans (don't have a custom implementation) and don't call the newly added method. Any way, I'm +1 to all this. > Merge Spans and SpanScorer > -------------------------- > > Key: LUCENE-6845 > URL: https://issues.apache.org/jira/browse/LUCENE-6845 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6845.patch, LUCENE-6845_norenames.patch, > LUCENE-6845_norenames.patch.txt > > > SpanScorer and Spans currently share the burden of scoring span queries, with > SpanScorer delegating to Spans for most operations. Spans is essentially a > Scorer, just with the ability to iterate through positions as well, and no > SimScorer to use for scoring. This seems overly complicated. We should > merge the two classes into one. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org