[ 
https://issues.apache.org/jira/browse/SOLR-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972574#comment-14972574
 ] 

Mark Miller commented on SOLR-8033:
-----------------------------------

Looks commented out in the hdfs version and not the regular version because 
it's a cut and paste and Path does not have the same methods as File. So it 
would need a simple tweak or two to work.

> useless if branch (commented out log.debug in HdfsTransactionLog constructor)
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-8033
>                 URL: https://issues.apache.org/jira/browse/SOLR-8033
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0, 5.1
>            Reporter: songwanging
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> In method HdfsTransactionLog() of class HdfsTransactionLog 
> (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)
> The if branch presented in the following code snippet performs no actions, we 
> should add more code to handle this or directly delete this if branch.
> HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String> 
> globalStrings, boolean openExisting) {
>   ...
>     try {
>       if (debug) {
>         //log.debug("New TransactionLog file=" + tlogFile + ", exists=" + 
> tlogFile.exists() + ", size=" + tlogFile.length() + ", openExisting=" + 
> openExisting);
>       }
> ...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to