[ 
https://issues.apache.org/jira/browse/LUCENE-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976919#comment-14976919
 ] 

Robert Muir commented on LUCENE-6840:
-------------------------------------

Can we add back a helper like this to DirectReader? I think it helps the api 
for the general case, where an offset from a slice is kinda silly (but i get 
where it helps for this case).

{code}
public static LongValues getInstance(RandomAccessInput slice, int bitsPerValue) 
{
  return getInstance(slice, bitsPerValue, 0);
}
{code}

thanks for adding the offset tests to directreader tests.

Should we move LongValues.EMPTY to DirectMonotonicReader since its the only one 
using it right now?



> Put ord indexes of doc values on disk
> -------------------------------------
>
>                 Key: LUCENE-6840
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6840
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6840.patch, LUCENE-6840.patch, LUCENE-6840.patch
>
>
> Currently we still load monotonic blocks into memory to map doc ids to an 
> offset on disk. Since these data structures are usually consumed sequentially 
> I would like to investigate putting them to disk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to