[
https://issues.apache.org/jira/browse/SOLR-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985647#comment-14985647
]
Mike Drob commented on SOLR-8223:
---------------------------------
In {{CoreContainer}}, {{zkSys.registerInZk}} doesn't declare any checked
exceptions, so we can narrow the scope to catching only unchecked ones. This
might help us notice API or compatibility changes in the future.
In {{LeaderInitiatedRecoveryThread}}, {{client.request}} declares both
{{SolrServerException}} and {{IOException}} so we still have to handle them in
some way. The existing code did not make a distinction between those and
{{RuntimeException}}, so I made the minimal changes I could. It would have been
reasonable to {{catch (IOException | SolrServerException | RuntimeException
e)}} but I didn't think of that at the time and I'm not sure it really adds
much value.
> Take care not to accidentally swallow OOMErrors
> -----------------------------------------------
>
> Key: SOLR-8223
> URL: https://issues.apache.org/jira/browse/SOLR-8223
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.10.3
> Reporter: Mike Drob
> Fix For: Trunk
>
> Attachments: SOLR-8223.patch
>
>
> This was first noticed with 4.10.3, but it looks like it still applies to
> trunk. There are a few places in the code where we catch {{Throwable}} and
> then don't check for OOM or rethrow it. This behaviour means that OOM kill
> scripts won't run, and the JVM can get into an undesirable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
