[ https://issues.apache.org/jira/browse/LUCENE-6874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987423#comment-14987423 ]
Steve Rowe commented on LUCENE-6874: ------------------------------------ bq. I just noticed that your patch contains hardcoded filenames of your local system, I think those are just leftovers from your testing with reuters. Yup, patch needs cleanup before it can be committed. I figured the decision about what to do hasn't been made yet, so I'll wait on doing that work until then. bq. Otherwise I am not happy about the size of the generated files, but thats how jflex works... I don't think the generated Java source makes much difference - the thing people will deal with is the JFlex source, and it's fairly compact. I looked at the .class file sizes on my system, and I see 13k for the JFlex version and 2k for the ICU version. > WhitespaceTokenizer should tokenize on NBSP > ------------------------------------------- > > Key: LUCENE-6874 > URL: https://issues.apache.org/jira/browse/LUCENE-6874 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis > Reporter: David Smiley > Priority: Minor > Attachments: LUCENE-6874-jflex.patch, LUCENE-6874.patch > > > WhitespaceTokenizer uses [Character.isWhitespace > |http://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#isWhitespace-int-] > to decide what is whitespace. Here's a pertinent excerpt: > bq. It is a Unicode space character (SPACE_SEPARATOR, LINE_SEPARATOR, or > PARAGRAPH_SEPARATOR) but is not also a non-breaking space ('\u00A0', > '\u2007', '\u202F') > Perhaps Character.isWhitespace should have been called > isLineBreakableWhitespace? > I think WhitespaceTokenizer should tokenize on this. I am aware it's easy to > work around but why leave this trap in by default? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org