[ 
https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994430#comment-14994430
 ] 

Terry Smith commented on LUCENE-6679:
-------------------------------------

Darn, sorry I didn't get back to pushing these new tests into the source, they 
would have helped to catch this.


It looks like branch_5x and trunk diverged here, this commit shows where this 
code was removed on branch_5x: 
https://github.com/apache/lucene-solr/commit/11cc6e53f85f7bc4b616bb38370ddfc704987337#diff-2b293bfd95e32f715a5c05b4e132f047L82

And this commit from trunk shows the move of Filter from Lucene to Solr: 
https://github.com/apache/lucene-solr/commit/98888f8d64d4fb34eb2480e9a667c45f262d20f0#diff-4bf1c256f49c1a4ee4a50b1f8aeda1ddL1

You can see the trunk version of the file here: 
https://github.com/apache/lucene-solr/blob/98888f8d64d4fb34eb2480e9a667c45f262d20f0/solr/core/src/java/org/apache/solr/search/Filter.java

The changes from the branch_5x commit are missing.

I don't know why this is the case, perhaps [~jpountz] can chime in as the 
original commit that fixes the explain output as a side effect (LUCENE-6601) 
looks like it ought to be on both branch_5x and trunk.



> Filter's Weight.explain returns an explanation with isMatch==true even on 
> documents that don't match
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6679
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6679
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>         Attachments: LUCENE-6679.patch
>
>
> This was reported by Trejkaz on the java-user list: 
> http://search-lucene.com/m/l6pAi19h4Y3DclgB1&subj=Re+What+on+earth+is+FilteredQuery+explain+doing+



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to