[ 
https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998582#comment-14998582
 ] 

Joel Bernstein edited comment on SOLR-8266 at 11/10/15 1:40 PM:
----------------------------------------------------------------

I haven't started. Feel free to start working on a patch. Here are the places 
that will need to be changed:

1) StreamHandler: Remove code that handles Java de-serialization. Always use 
Streaming Expressions.
2) ParallelStream: Remove code that handles Java serialization. Always use 
Streaming Expressions.
3) StreamingTest: Change all parallels tests so that the StreamFactory is 
properly configured and added to the StreamContext. Then set the StreamContext 
on to the TupleStream before calling the getTuples() method. The StreamHandler 
does this logic so you can copy the behavior from there.

I'll be happy to review your work.


was (Author: joel.bernstein):
I haven't started. Feel free to start working on a patch. Here are the places 
that will need to be changed:

1) StreamHandler: Remove code that handles Java de-serialization. Always use 
Streaming Expressions.
2) ParallelStream: Remove code that handles Java serialization. Always use 
Streaming Expressions.
3) StreamingTest: Change all parallels tests so that the StreamFactory is 
properly configured and added to the StreamContext. Then set the StreamContext 
of the TupleStream before calling the getTuples() method. The StreamHandler 
does this logic so you copy the behavior from there.

I'll be happy to review your work.

> Remove Java Serialization from the Streaming API
> ------------------------------------------------
>
>                 Key: SOLR-8266
>                 URL: https://issues.apache.org/jira/browse/SOLR-8266
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Joel Bernstein
>
> This is being done mainly for security reasons but it's also architecturally 
> the right thing to do.
> Going forward only Streaming Expressions will be used to serialize Streaming 
> API Objects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to