[
https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000683#comment-15000683
]
Mark Miller commented on SOLR-8075:
-----------------------------------
The latest patch also fixes LIR handling a bit. The way things worked were a
little off.
If you were the first replica to attempt to be leader, LIR would never stop you
early. Instead, things would fail when publish ACTIVE was attempted. That is
not good, because it will probably prevent the next leader from trying to take
over.
So I have moved all the LIR checking code in ElectionContext to a new spot.
It's always checked, first attempted leader or not. And not until we see if the
replica *could* be leader and if all the replicas participated in that election
or not.
> Leader Initiated Recovery should not stop a leader that participated in an
> election with all of it's replicas from becoming a valid leader.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8075
> URL: https://issues.apache.org/jira/browse/SOLR-8075
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8075.patch, SOLR-8075.patch, SOLR-8075.patch,
> SOLR-8075.patch, SOLR-8075.patch, SOLR-8075.patch, SOLR-8075.patch
>
>
> Currently, because of SOLR-8069, all the replicas in a shard can be put into
> LIR.
> If you restart such a shard, the valid leader will will win the election and
> sync with the shard and then be blocked from registering as ACTIVE because it
> is in LIR.
> I think that is a little wonky because I don't think it even tries another
> candidate because the leader that cannot publish ACTIVE does not have it's
> election canceled.
> While SOLR-8069 should prevent this situation, we should add logic to allow a
> leader that can sync with it's full shard to become leader and publish ACTIVE
> regardless of LIR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
