[
https://issues.apache.org/jira/browse/LUCENE-6874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000940#comment-15000940
]
Uwe Schindler commented on LUCENE-6874:
---------------------------------------
bq. Why persist the bitset and deal with the build issues around that when
instead it could be done in-memory in a static initializer? It's so cheap to
build that I question the effort in pre-building it as part of the build
process.
Where to get the information for the bitset from? The Unicode data as of
java.lang.Character class is wrong! :-) My idea was to use a Unicode data file
and extract all Whitespace characters in a build tool. Shipping with the
usicode data file would be a large overhead.
bq. On 5.x, Uwe, Adrien, how do you feel about the WhitespaceTokenizerFactory I
have in the patch with the "rule" attribute to pick?
I am not happy, but could live with it.
> WhitespaceTokenizer should tokenize on NBSP
> -------------------------------------------
>
> Key: LUCENE-6874
> URL: https://issues.apache.org/jira/browse/LUCENE-6874
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: David Smiley
> Priority: Minor
> Attachments: LUCENE-6874-jflex.patch, LUCENE-6874.patch,
> LUCENE_6874_jflex.patch
>
>
> WhitespaceTokenizer uses [Character.isWhitespace
> |http://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#isWhitespace-int-]
> to decide what is whitespace. Here's a pertinent excerpt:
> bq. It is a Unicode space character (SPACE_SEPARATOR, LINE_SEPARATOR, or
> PARAGRAPH_SEPARATOR) but is not also a non-breaking space ('\u00A0',
> '\u2007', '\u202F')
> Perhaps Character.isWhitespace should have been called
> isLineBreakableWhitespace?
> I think WhitespaceTokenizer should tokenize on this. I am aware it's easy to
> work around but why leave this trap in by default?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
