[
https://issues.apache.org/jira/browse/SOLR-8287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003887#comment-15003887
]
Christine Poerschke commented on SOLR-8287:
-------------------------------------------
The {{TrieDoubleField}} change is similar to what {{TrieFloatField}} currently
has, that looks good to me.
The {{TrieLongField}} change is similar to what {{TrieIntField}} currently has,
but I'm wondering:
* {{TrieIntField.toNativeType}} attempts {{Float.parseFloat}} if the
{{Integer.parseInt}} attempt throws a {{NumberFormatException}}
* in the current patch {{TrieLongField.toNativeType}} attempts
{{Float.parseFloat}} if the {{Long.parseLong}} attempt throws a
{{NumberFormatException}} but might {{Double.parseDouble}} be attempted instead?
> TrieLongField and TrieDoubleField should override toNativeType
> --------------------------------------------------------------
>
> Key: SOLR-8287
> URL: https://issues.apache.org/jira/browse/SOLR-8287
> Project: Solr
> Issue Type: Bug
> Reporter: Ishan Chattopadhyaya
> Attachments: SOLR-8287.patch
>
>
> Although the TrieIntField and TrieFloatField override the toNativeType()
> method, the TrieLongField and TrieDoubleField do not do so.
> This method is called during atomic updates by the AtomicUpdateDocumentMerger
> for the "set" operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
